Skip to content

chore(deps): update markdown-link-check to 3.14.1#1548

Merged
jennifer-shehane merged 4 commits into
cypress-io:masterfrom
MikeMcC399:update/markdown-link-check
Oct 17, 2025
Merged

chore(deps): update markdown-link-check to 3.14.1#1548
jennifer-shehane merged 4 commits into
cypress-io:masterfrom
MikeMcC399:update/markdown-link-check

Conversation

@MikeMcC399
Copy link
Copy Markdown
Collaborator

@MikeMcC399 MikeMcC399 commented Oct 11, 2025

Situation

The currently used markdown-link-check@3.13.7 has two shortcomings that are apparent in this repo:

  • It logs an HTTP 403 Forbidden error checking https://www.npmjs.com/
  • It reports success although there were link errors

Change

Verification

npm ci
npm run check:markdown-links

Confirm no bad links reported

cat > missing.md <<EOT
[bad link](https://github.com/cypress-io/github-action/missing.md)
EOT
npm run check:markdown-links
echo "exit status should be non-zero for failure: " $?
rm missing.md

Check that a non-zero exit status is reported when a deliberate link error is checked.

@cypress-app-bot
Copy link
Copy Markdown
Collaborator

@MikeMcC399 MikeMcC399 added bug Something isn't working type: dependencies labels Oct 11, 2025
@MikeMcC399 MikeMcC399 self-assigned this Oct 11, 2025
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 11, 2025 17:28
@MikeMcC399 MikeMcC399 requested review from jennifer-shehane and removed request for jennifer-shehane October 17, 2025 09:06
@jennifer-shehane jennifer-shehane merged commit eb6ecdb into cypress-io:master Oct 17, 2025
79 checks passed
@MikeMcC399 MikeMcC399 deleted the update/markdown-link-check branch October 17, 2025 15:01
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 6.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants